Cosmetic filters flatbuffers #505
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
force-pushed
the
cosmetic-filter-fb-v6
branch
2 times, most recently
from
7818ee6 to
d5190b8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 2cecafe | Previous: 5f5fe77 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2226818763 ns/iter (± 14134997) |
2234242439 ns/iter (± 24252201) |
1.00 |
rule-match-first-request/brave-list |
1138764 ns/iter (± 7776) |
991058 ns/iter (± 5882) |
1.15 |
blocker_new/brave-list |
155603458 ns/iter (± 1731560) |
149229467 ns/iter (± 2125308) |
1.04 |
blocker_new/brave-list-deserialize |
19852541 ns/iter (± 426746) |
60347926 ns/iter (± 2771489) |
0.33 |
memory-usage/brave-list-initial |
10072827 ns/iter (± 3) |
18831613 ns/iter (± 3) |
0.53 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1534760 ns/iter (± 3) |
1515544 ns/iter (± 3) |
1.01 |
memory-usage/brave-list-1000-requests |
2516487 ns/iter (± 3) |
2505592 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
66641 ns/iter (± 3) |
66139 ns/iter (± 3) |
1.01 |
url_cosmetic_resources/brave-list |
204199 ns/iter (± 989) |
207675 ns/iter (± 3578) |
0.98 |
cosmetic-class-id-match/brave-list |
16225855 ns/iter (± 4936651) |
4286289 ns/iter (± 1184085) |
3.79 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 2cecafe | Previous: 5f5fe77 | Ratio |
|---|---|---|---|
rule-match-first-request/brave-list |
1138764 ns/iter (± 7776) |
991058 ns/iter (± 5882) |
1.15 |
cosmetic-class-id-match/brave-list |
16225855 ns/iter (± 4936651) |
4286289 ns/iter (± 1184085) |
3.79 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
cosmetic-filter-fb-v6
branch
from
d5190b8 to
c8e0ffb
Compare
atuchin-m
force-pushed
the
cosmetic-filter-fb-v6
branch
from
a3ba04d to
2cecafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.